Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: otelbench #183

Closed
wants to merge 9 commits into from
Closed

feat: otelbench #183

wants to merge 9 commits into from

Conversation

ernado
Copy link
Member

@ernado ernado commented Oct 3, 2023

No description provided.

@ernado ernado changed the base branch from main to feat/metrics October 3, 2023 15:30
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Attention: 138 lines in your changes are missing coverage. Please review.

Comparison is base (ffbdafe) 52.08% compared to head (1cdee1e) 52.77%.
Report is 2 commits behind head on feat/metrics.

❗ Current head 1cdee1e differs from pull request most recent head 218e251. Consider uploading reports for the commit 218e251 to get more accurate results

Additional details and impacted files
@@               Coverage Diff                @@
##           feat/metrics     #183      +/-   ##
================================================
+ Coverage         52.08%   52.77%   +0.68%     
================================================
  Files               152      149       -3     
  Lines             11532    11379     -153     
================================================
- Hits               6007     6005       -2     
+ Misses             5280     5128     -152     
- Partials            245      246       +1     
Files Coverage Δ
internal/metricstorage/schema.go 0.00% <0.00%> (ø)
internal/ytstorage/sharding.go 19.00% <19.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ernado ernado marked this pull request as draft October 5, 2023 13:35
@ernado ernado closed this Oct 5, 2023
@ernado ernado deleted the feat/otelbench branch December 1, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants